[DON'T MERGE] preview PR for fix retry loop for hcsshim:GetContainers #38595
Open
andrey-ko wants to merge 3 commits intomoby:masterfrom
Open
[DON'T MERGE] preview PR for fix retry loop for hcsshim:GetContainers #38595andrey-ko wants to merge 3 commits intomoby:masterfrom
andrey-ko wants to merge 3 commits intomoby:masterfrom
Conversation
|
Please sign your commits following these rules: $ git clone -b "pre-fix-retry-loop" git@github.com:andrey-ko/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357811352
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Andrey Kolomentsev <andrey.kolomentsev@docker.com>
Signed-off-by: Andrey Kolomentsev <andrey.kolomentsev@docker.com>
for windows all networks are re-populated in the store during network controller initialization. In current version it also regenerate network Ids which may be referenced by other components and it may cause broken references to a networks. This commit avoids regeneration of network ids. Signed-off-by: Andrey Kolomentsev <andrey.kolomentsev@docker.com>
301e2e4 to
d47298d
Compare
Contributor
|
@andrey-ko what is status of this? TestStartReturnCorrectExitCode failure happens quite often so it would be nice to get it fixed? |
Contributor
Author
|
@olljanat waiting when PR microsoft/hcsshim#457 will get merged |
Member
|
ping @ddebroy should we close this one, or do you want to keep it opened and carry? |
This was referenced Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preview PR that fixes flaky test 'TestStartReturnCorrectExitCode' on windows RS1.
Caused by outdated error check returned by hcsshim::GetContainers in retry loop:
moby/daemon/graphdriver/windows/windows.go
Line 276 in 5ec3138
It was discovered and investigated in #38580 (comment)