@andrey-ko PTAL

@ddebroy @andrey-ko Waaaaaaay too early and much is in flux.

Codecov Report

Merging #38541 into master will increase coverage by 0.54%.
The diff coverage is 26.54%.

@@            Coverage Diff             @@
##           master   #38541      +/-   ##
==========================================
+ Coverage   36.47%   37.01%   +0.54%     
==========================================
  Files         613      610       -3     
  Lines       45814    45321     -493     
==========================================
+ Hits        16709    16775      +66     
+ Misses      26823    26260     -563     
- Partials     2282     2286       +4

Ah, well, whatever information would be useful then (instead of runhcs) 😅

@andrey-ko when you get a chance, can you have a look a verifying this PR with windows binaries according to the john howard instructions? cc @ddebroy

@jhowardmsft in regards to getting PR jobs modified to test with containerd on windows in the future and getting nightly builds up with the new dependent binaries, we should proceed with that in parallel with this PR cc @dave-tucker

(could use msft help on this if you guys got canonical ways to build windows binaries from golang in an automated pipeline)

The runhcs.exe is required, I otherwise got this I couldn't run or kill containers.

PS C:\Program Files\Docker> docker run mcr.microsoft.com/windows/nanoserver:1809 ipconfig
...
C:\Program Files\Docker\docker.exe: Error response from daemon: exec: "runhcs.exe": executable file not found in %!P(MISSING)ATH%!(NOVERB): unknown.

Interesting. It shouldn’t be needed. I’ll fix it as a followup

%!P(MISSING)ATH%!(NOVERB)

Looks like an incorrect format-string somewhere as well 🤔

@StefanScherer doesn't repro here. Are you POSITIVE you are using the right shim binary?

@jhowardmsft I tried a Dockerfile using double quotes.

# escape=`
ARG core=mcr.microsoft.com/windows/servercore:1809
ARG target=mcr.microsoft.com/windows/servercore:1809
FROM $core as download

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

ENV GPG_VERSION 2.3.4

RUN Invoke-WebRequest "https://files.gpg4win.org/gpg4win-vanilla-${env:GPG_VERSION}.exe" -OutFile "gpg4win.exe" -UseBasicParsing ; `
    Start-Process .\gpg4win.exe -ArgumentList '/S' -NoNewWindow -Wait

Single line RUN instructions seem to work 🎉 💯. What a relief.
But I have problems with this multi-line

RUN @( 
    "94AE36675C464D64BAFA68DD7434390BDBE9B9C5", 
    "FD3A5288F042B6850C66B31F09FE44734EB7990E", 
    "71DCFD284A79C3B38668286BC97EC7A07EDE3FC1", 
    "DD8F2338BAE7501E3DD5AC78C273792F7D83545D", 
    "C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8", 
    "B9AE9905FFD7803F25714661B63B535A4C206CA9", 
    "77984A986EBC2AA786BC0F66B01FBB92821C587A", 
    "8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600", 
    "4ED778F539E3634C779C87C6D7062848A1AB005C", 
    "A48C2BEE680E841632CD4E44F07496B3EB3C1762", 
    "B9E2F5981AA6E0CD28160D9FF13993A75599653C" 
    ) | foreach { 
      gpg --keyserver ha.pool.sks-keyservers.net --recv-keys $_ ; 
    }

Sure I can keep single quotes here, but wanted to try out where people might use it.

Is that a regression (the multi-line)?

@jhowardmsft oh the shim was my fault, I accidentally copied the wrong one :-(

FROM mcr.microsoft.com/windows/servercore:1809
ENV VERSION=1.2.3
RUN powershell -Command Write-Output "The version is $env:VERSION"
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
RUN Write-Output "The version is $env:VERSION"

Building this Dockerfile gives me

PS C:\node\quoteetst> docker build --no-cache -t test .
Sending build context to Docker daemon  2.048kB
Step 1/5 : FROM mcr.microsoft.com/windows/servercore:1809
 ---> 1206cbf9524c
Step 2/5 : ENV VERSION=1.2.3
 ---> Running in 1bd568e4ee34
Removing intermediate container 1bd568e4ee34
 ---> 0a74f370c77f
Step 3/5 : RUN powershell -Command Write-Output "The version is $env:VERSION"
 ---> Running in d6a007ab1b1e
The
version
is
1.2.3
Removing intermediate container d6a007ab1b1e
 ---> 0342b5e97e70
Step 4/5 : SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
 ---> Running in 37f64078846b
Removing intermediate container 37f64078846b
 ---> 256f3d5579da
Step 5/5 : RUN Write-Output "The version is $env:VERSION"
 ---> Running in 0b5f8071c718
The
version
is
1.2.3
Removing intermediate container 0b5f8071c718
 ---> a27d43c226db
Successfully built a27d43c226db
Successfully tagged test:latest

The output is multi-line so there were no quotes in the Write-Output command. My download from the previous Dockerfile fortunately worked without the quotes.

I've access problems with container removal:

PS C:\Users\akolomentsev> docker run --rm -it mcr.microsoft.com/windows/nanoserver:1803
Microsoft Windows [Version 10.0.17134.648]
(c) 2018 Microsoft Corporation. All rights reserved.

C:\>exit
ERRO[0005] Error waiting for container: container a2d618fa593f2f4992590a92ac49e2317497b088ba4fb6a383cee40491de1cb7: driver "windowsfilter" failed to remove root filesystem: failed to detach VHD: invalid argument: rename C:\ProgramData\Docker\windowsfilter\a2d618fa593f2f4992590a92ac49e2317497b088ba4fb6a383cee40491de1cb7 C:\ProgramData\Docker\windowsfilter\a2d618fa593f2f4992590a92ac49e2317497b088ba4fb6a383cee40491de1cb7-removing: Access is denied.

and looks like it stays forever in "removal in progress state"....

PS C:\Users\akolomentsev> docker container ls -a
CONTAINER ID        IMAGE                                       COMMAND                    CREATED              STATUS                PORTS               NAMES
a2d618fa593f        mcr.microsoft.com/windows/nanoserver:1803   "c:\\windows\\system32…"   About a minute ago   Removal In Progress                       sleepy_beaver
PS C:\Users\akolomentsev>

Removal issue known and understood. Needs a fix to the shim which is in flight

@StefanScherer I’m still trying to understand if this is a regression or not. Can you be more precise?

@jhowardmsft I think I remembered something wrong. I kept in my mind that I sometime should test this PR to check an enhancement how we can use quotes in RUN instructions. As I finally had some time today to set everything up I tried it out in the hope that we can use double quotes, but it seems I remembered this wrong. So no regression, it just doesn't work as it would be nice to work. So forget about this false alarm. We should track this in another issue.

All other things with containerd work for me on a Server 2019, even docker run --rm.

I’m going to merge this so we can move forward given there are three LGTMs and a slack-LGTM from Derek. @thaJeztah YOLO.

( channeling @jessfraz 😱 😁)

😂🥳🎉