Skip to content

Update docker-py to 3.7.0#38524

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:update_docker_py
Jan 15, 2019
Merged

Update docker-py to 3.7.0#38524
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:update_docker_py

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 9, 2019 •
edited
Loading

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 9, 2019

@shin- @LinuxMercedes

@LinuxMercedes
Copy link
Copy Markdown
Contributor

LinuxMercedes commented Jan 9, 2019

Thanks! This patch has really come full-circle--I originally found the bug via a project I have which uses docker-py 😄

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #38524 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38524      +/-   ##
==========================================
- Coverage   36.62%   36.62%   -0.01%     
==========================================
  Files         608      608              
  Lines       45174    45174              
==========================================
- Hits        16546    16544       -2     
- Misses      26339    26342       +3     
+ Partials     2289     2288       -1

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 9, 2019

@LinuxMercedes 😂 that made me laugh

@shin- I updated the installation to use pip now (as we were discussing on Slack); let's see if it passes without python-setuptools and python-wheel, otherwise I add those back.

</end-python-n00b-mode>

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 9, 2019

Looks like python-setuptools was needed for installing yamllint

@thaJeztah thaJeztah force-pushed the update_docker_py branch 2 times, most recently from 0cacf09 to 5acebde Compare January 10, 2019 01:16
@thaJeztah thaJeztah changed the title Update docker-py to 1073b7364846709ad005e7991045d38365d911c9 Update docker-py to 55a62c26e7384b4020448ad68ee4fbe922be8836 Jan 10, 2019
@thaJeztah thaJeztah mentioned this pull request Jan 10, 2019
Closed
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2019

removed the changes to use pip; moving that to a separate PR (#38526), because s390x and PowerPC look to have issues with that

@thaJeztah thaJeztah changed the title Update docker-py to 55a62c26e7384b4020448ad68ee4fbe922be8836 Update docker-py to 3.7.0 Jan 10, 2019
@thaJeztah thaJeztah force-pushed the update_docker_py branch 2 times, most recently from 3cf2801 to aae0255 Compare January 10, 2019 23:24
@thaJeztah
Update docker-py to 3.7.0
c0c05af 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2019

ok; think I have it going now.

it just occurred to me that we don't even run the docker-py tests on s390x, powerpc or arm, so I actually want to do a follow-up to see if I can rewrite the Dockerfile to skip installation on those platforms.

CI does not (yet) use BuildKit, so skipping build-stages is not really possible yet, but perhaps with some script hacks for the time being.

yongtang
yongtang approved these changes Jan 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once janky is 🍏

@olljanat
Copy link
Copy Markdown
Contributor

olljanat commented Jan 13, 2019

Ready for merge?

@AkihiroSuda AkihiroSuda merged commit ef91b40 into moby:master Jan 15, 2019
@thaJeztah thaJeztah deleted the update_docker_py branch January 15, 2019 02:48
@LinuxMercedes LinuxMercedes mentioned this pull request Apr 30, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+2 more reviewers

@shin- shin- shin- approved these changes

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thaJeztah @LinuxMercedes @olljanat @shin- @yongtang @AkihiroSuda @GordonTheTurtle