Merged
Conversation
This import got lost after commit 56cc56b was merged, likely because the PR was built against an outdated master. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @vdemeester @tiborvass PTAL |
Member
Author
|
haha 💩happens |
Member
Author
|
I'll move this to "merge"; when build passes, I think we can just merge this |
This was referenced Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38361
This import got lost after commit 56cc56b (#38126) was merged, likely because the PR was built against an outdated master and #38316 was just merged before the PR.