Skip to content

WIP: Use windowsRS4 instead of RS1#37862

Closed
olljanat wants to merge 1 commit intomoby:masterfrom
olljanat:use-windowsRS4
Closed

WIP: Use windowsRS4 instead of RS1#37862
olljanat wants to merge 1 commit intomoby:masterfrom
olljanat:use-windowsRS4

Conversation

@olljanat
Copy link
Copy Markdown
Contributor

@olljanat olljanat commented Sep 16, 2018

I noticed that example

moby/integration-cli/docker_api_containers_windows_test.go

Line 22 in 8e610b2

testRequires(c, SameHostDaemon, DaemonIsWindowsAtLeastBuild(16299)) // Named pipe support was added in RS3
test does not run on current windowsRS1 node so I wanted to check if that would work by using RS4 which looks to be there (if I understood this one correctly).

So this PR is there now to be able to see if tests passes on that version.

@olljanat
Use windowsRS4 instead of RS1
f40c17e 
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
@olljanat
Copy link
Copy Markdown
Contributor Author

olljanat commented Sep 16, 2018

Looks that this change didn't take effect.
Is there some way to try build on newer Windows version or is only way that some changes it on Jenkins side?

If I understand this right we want use Docker-PRs-WoW-RS4-Process (or Docker-PRs-WoW-RS4-HyperV) instead of Docker-PRs-WoW-RS1

@jhowardmsft I can see that at least you have been running something using https://jenkins.dockerproject.org/label/windows-rs4/

@olljanat olljanat mentioned this pull request Sep 16, 2018
Merged
@lowenna
Copy link
Copy Markdown
Member

lowenna commented Sep 17, 2018

No, it's a lot more complex. There are dedicated RS1 machines for CI that I maintain. The RS4 (soon to be RS5) machines aren't online. What you changed was the labels for the rebuild tags that maintainers have on this repo to restart CI. There's no actual non-RS1 CI available in this project currently publicly.

@olljanat
Copy link
Copy Markdown
Contributor Author

olljanat commented Sep 17, 2018

Ok. It bit hard to understand as these Jenkins jobs are not documented online.

@olljanat olljanat closed this Sep 17, 2018
@olljanat olljanat deleted the use-windowsRS4 branch September 30, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/0-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olljanat @lowenna @GordonTheTurtle