Skip to content

Update Microsoft/go-winio to 0.4.8#37364

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_go_winio
Jun 29, 2018
Merged

Update Microsoft/go-winio to 0.4.8#37364
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_go_winio

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Fixes named pipe support for hyper-v isolated containers

fixes #36562 ("Cannot locate Windows named pipe "docker_engine" after passing -v \.\pipe\docker_engine:\.\pipe\docker_engine")

Full diff: microsoft/go-winio@v0.4.7...v0.4.8; changes included:

- Description for the changelog

- Fix error "Cannot locate Windows named pipe" when bind-mounting mounting Windows named pipes in a container

- A picture of a cute animal (not mandatory but encouraged)

Fixes named pipe support for hyper-v isolated containers

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

ping @johnstep @jstarks PTAL

Copy link
Copy Markdown
Contributor

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selansen
Copy link
Copy Markdown
Contributor

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1d7132e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37364   +/-   ##
=========================================
  Coverage          ?   34.85%           
=========================================
  Files             ?      610           
  Lines             ?    45001           
  Branches          ?        0           
=========================================
  Hits              ?    15684           
  Misses            ?    27207           
  Partials          ?     2110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot locate Windows named pipe "docker_engine" after passing -v \\.\pipe\docker_engine:\\.\pipe\docker_engine

6 participants