Fix TestDaemonNoSpaceLeftOnDeviceError#37315
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 20, 2018
Merged
Conversation
This test is testing if any "no space left on device" errors
that occur during `docker pull` will not be masked by other
errors. To test for this, a new loopback-device was created,
and used as `--data-dir` ("/var/lib/docker").
However, `/var/lib/docker` is used for storing various
other things, including a `cache.db` database, used by
BuildKit, which is created during startup of the daemon.
Creation of that file failed (due to `--data-dir` path
being on a mount with limited size), which caused daemon
start to fail before the test was able to run.
This patch changes the size-limited mount to be used for
the storage-driver directory only, so that the test is
not affected by other parts of the code attempting to
write files in it.
To have a predictable path; the daemon used in this test
is configured to use the `vfs` storage-driver.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @tonistiigi @vdemeester PTAL |
tonistiigi
approved these changes
Jun 20, 2018
This was referenced Jun 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #37315 +/- ##
=========================================
Coverage ? 34.81%
=========================================
Files ? 609
Lines ? 45000
Branches ? 0
=========================================
Hits ? 15667
Misses ? 27218
Partials ? 2115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is testing if any "no space left on device" errors
that occur during
docker pullwill not be masked by othererrors. To test for this, a new loopback-device was created,
and used as
--data-dir("/var/lib/docker").However,
/var/lib/dockeris used for storing variousother things, including a
cache.dbdatabase, used byBuildKit, which is created during startup of the daemon.
Creation of that file failed (due to
--data-dirpathbeing on a mount with limited size), which caused daemon
start to fail before the test was able to run.
This patch changes the size-limited mount to be used for
the storage-driver directory only, so that the test is
not affected by other parts of the code attempting to
write files in it.
To have a predictable path; the daemon used in this test
is configured to use the
vfsstorage-driver.Fixes #37277