do not stop health check before sending signal#37263
Closed
Conversation
Author
|
Do i need to start an issue to describe the bug? |
Contributor
|
ping docker maintainers @cpuguy83 @vdemeester @thaJeztah |
thaJeztah
approved these changes
Jun 20, 2018
Member
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM, but would like some other maintainers to have a look as well, in case I overlook something
ping @mlaventure @vdemeester @tonistiigi PTAL
cpuguy83
requested changes
Jun 20, 2018
Member
cpuguy83
left a comment
There was a problem hiding this comment.
Can you add a test case for this?
Contributor
|
Thanks for the PR @Kazero0, the change makes sense to me, I would indeed consider it a bug fix, but a test would be useful indeed :) |
Codecov Report
@@ Coverage Diff @@
## master #37263 +/- ##
==========================================
- Coverage 36.54% 35.08% -1.47%
==========================================
Files 608 608
Lines 45036 44967 -69
==========================================
- Hits 16460 15778 -682
- Misses 26295 27079 +784
+ Partials 2281 2110 -171 |
Author
|
Sorry that I've forgotten this patch. :( |
Docker daemon always stops healthcheck before sending signal to a container now. However, when we use "docker kill" to send signals other than SIGTERM or SIGKILL to a container, such as SIGINT, daemon still stops container health check though container process handles the signal normally and continues to work. Signed-off-by: Ruilin Li <liruilin4@huawei.com>
This was referenced Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker daemon always stops healthcheck now before sending signal
to a container now. However, when we use "docker kill" to send
signals other than SIGTERM or SIGKILL to a container, such as SIGINT,
daemon still stops container health check though container process
handles the signal normally and continues to work.
- What I did
Fix that container health check stops working when sending signals to a container by
docker kill.- How I did it
Do not stop health check before sending signal to a container.
Daemon state monitor can stop health check when container state changes to exit.
- How to verify it
Run a container with health check.
Send signal other than SIGTERM or SIGKILL to container by
docker kill.Check container health status by
docker inspect.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)