Skip to content

Update gotestyourself to gotest.tools#37243

Merged
vdemeester merged 2 commits intomoby:masterfrom
vdemeester:gotestyourself-with-tools
Jun 13, 2018
Merged

Update gotestyourself to gotest.tools#37243
vdemeester merged 2 commits intomoby:masterfrom
vdemeester:gotestyourself-with-tools

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Jun 8, 2018

github.com/gotestyourself/gotestyourself moved to gotest.tools with version 2.0.0. Moving to that one, bumping it to v2.1.0.

most-beautiful-cats-world-3

@vdemeester vdemeester changed the title Update gotestyourself by gotest.tools Update gotestyourself to gotest.tools Jun 8, 2018
@thaJeztah
Copy link
Member

thaJeztah commented Jun 8, 2018

Full diff between current, and v2.0.0: gotestyourself/gotest.tools@cf3a5ab...v2.0.0

And v2.1.0: gotestyourself/gotest.tools@cf3a5ab...v2.1.0

yongtang
yongtang approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Jun 8, 2018

PowerPC looks like a flaky https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/10151/console

18:05:31 FAIL: check_test.go:347: DockerSwarmSuite.TearDownTest
18:05:31 
18:05:31 unmount of /tmp/docker-execroot/d29a48e026ecc/netns failed: invalid argument
18:05:31 unmount of /tmp/docker-execroot/db2a69f06c7ab/netns failed: no such file or directory
18:05:31 check_test.go:352:
18:05:31     d.Stop(c)
18:05:31 /go/src/github.com/docker/docker/internal/test/daemon/daemon.go:401:
18:05:31     t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
18:05:31 ... Error: Error while stopping the daemon d8b1b92b3cf89 : exit status 130
18:05:31 
18:05:31 
18:05:31 ----------------------------------------------------------------------
18:05:31 PANIC: docker_api_swarm_test.go:780: DockerSwarmSuite.TestAPISwarmRestartCluster
18:05:31 
18:05:31 [d29a48e026ecc] waiting for daemon to start
18:05:31 [d29a48e026ecc] daemon started
18:05:31 
18:05:31 [db2a69f06c7ab] waiting for daemon to start
18:05:31 [db2a69f06c7ab] daemon started
18:05:31 
18:05:31 [d8b1b92b3cf89] waiting for daemon to start
18:05:31 [d8b1b92b3cf89] daemon started
18:05:31 
18:05:31 [dc0f6b4444a93] waiting for daemon to start
18:05:31 [dc0f6b4444a93] daemon started
18:05:31 
18:05:31 [d862c182dbb7e] waiting for daemon to start
18:05:31 [d862c182dbb7e] daemon started
18:05:31 
18:05:31 [db4667e08d5f0] waiting for daemon to start
18:05:31 [db4667e08d5f0] daemon started
18:05:31 
18:05:31 [d29a48e026ecc] exiting daemon
18:05:31 [db4667e08d5f0] exiting daemon
18:05:31 [d8b1b92b3cf89] exiting daemon
18:05:31 [db2a69f06c7ab] exiting daemon
18:05:31 [d862c182dbb7e] exiting daemon
18:05:31 [dc0f6b4444a93] exiting daemon
18:05:31 [dc0f6b4444a93] waiting for daemon to start
18:05:31 [db4667e08d5f0] waiting for daemon to start
18:05:31 [d8b1b92b3cf89] waiting for daemon to start
18:05:31 [d862c182dbb7e] waiting for daemon to start
18:05:31 [db2a69f06c7ab] waiting for daemon to start
18:05:31 [d29a48e026ecc] waiting for daemon to start
18:05:31 [d8b1b92b3cf89] daemon started
18:05:31 
18:05:31 [db4667e08d5f0] daemon started
18:05:31 
18:05:31 [dc0f6b4444a93] daemon started
18:05:31 
18:05:31 [d29a48e026ecc] daemon started
18:05:31 
18:05:31 [d862c182dbb7e] daemon started
18:05:31 
18:05:31 [db2a69f06c7ab] daemon started
18:05:31 
18:05:31 [d29a48e026ecc] exiting daemon
18:05:31 [db2a69f06c7ab] exiting daemon
18:05:31 [d8b1b92b3cf89] daemon started
18:05:31 Attempt #2: daemon is still running with pid 6069
18:05:31 Attempt #3: daemon is still running with pid 6069
18:05:31 Attempt #4: daemon is still running with pid 6069
18:05:31 [d8b1b92b3cf89] exiting daemon
18:05:31 ... Panic: Fixture has panicked (see related PANIC)
18:05:31

Timeout / hang on Experimental https://jenkins.dockerproject.org/job/Docker-PRs-experimental/40985/console

18:30:48 --- FAIL: Test (5216.96s)
18:30:48 panic: DockerNetworkSuite.TestDockerNetworkCustomIPAM test timed out after 5m0s [recovered]
18:30:48 	panic: DockerNetworkSuite.TestDockerNetworkCustomIPAM test timed out after 5m0s
18:30:48

thaJeztah
thaJeztah approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green, but let's check if it doesn't conflict with some other big PR's that are currently pending before we merge

We should also backport this to current release branches

@vdemeester
Copy link
Member Author

vdemeester commented Jun 9, 2018

Ah also, hold on to merge this one, I'm gonna need to update TESTING.md too 👼

@vdemeester vdemeester force-pushed the gotestyourself-with-tools branch from 662f77d to 381dc4c Compare June 11, 2018 13:09
@codecov
Copy link

codecov bot commented Jun 11, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c752b09). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37243   +/-   ##
=========================================
  Coverage          ?   35.09%           
=========================================
  Files             ?      608           
  Lines             ?    44968           
  Branches          ?        0           
=========================================
  Hits              ?    15780           
  Misses            ?    27079           
  Partials          ?     2109

@vdemeester vdemeester force-pushed the gotestyourself-with-tools branch from 381dc4c to b6f7447 Compare June 11, 2018 13:32
@vdemeester vdemeester force-pushed the gotestyourself-with-tools branch from b6f7447 to 0068f3c Compare June 12, 2018 07:06
@vdemeester
Replace gotestyourself by gotest.tools
c147e9e 
github.com/gotestyourself/gotestyourself moved to gotest.tools with
version 2.0.0. Moving to that one, bumping it to v2.1.0.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Update tests to use gotest.tools 👼
3845728 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the gotestyourself-with-tools branch from 0068f3c to 3845728 Compare June 13, 2018 07:09
@vdemeester vdemeester mentioned this pull request Jun 13, 2018
Closed
@vdemeester vdemeester merged commit 692df46 into moby:master Jun 13, 2018
@vdemeester vdemeester deleted the gotestyourself-with-tools branch June 13, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83 cpuguy83 is a code owner

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

+2 more reviewers

@dnephin dnephin dnephin approved these changes

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vdemeester @thaJeztah @dnephin @yongtang @GordonTheTurtle