Migrate test-integration-cli experimental build tests to integration#36746
Merged
vdemeester merged 1 commit intomoby:masterfrom Apr 9, 2018
Merged
Migrate test-integration-cli experimental build tests to integration#36746vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
All `docker build` tests that require an `ExperimentalDaemon` are migrated to `integration/build` package and start an experimental daemon to test on it. The end goal being to remove the `experimental` builds. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
commented
Mar 30, 2018
| } | ||
|
|
||
| // FIXME(vdemeester) should migrate to docker/cli tests | ||
| func (s *DockerSuite) TestBuildIidFileSquash(c *check.C) { |
Member
Author
There was a problem hiding this comment.
Working on writing the test on docker/cli 👼
Codecov Report
@@ Coverage Diff @@
## master #36746 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 613
Lines ? 45565
Branches ? 0
=========================================
Hits ? 15928
Misses ? 27549
Partials ? 2088 |
17 tasks
thaJeztah
approved these changes
Apr 6, 2018
| container.WithImage(name), | ||
| container.WithCmd("/bin/sh", "-c", "[ ! -f /remove_me ]"), | ||
| ) | ||
| container.Run(t, ctx, client, |
Member
There was a problem hiding this comment.
nit: these two runs can probably be combined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
docker buildtests that require anExperimentalDaemonaremigrated to
integration/buildpackage and start an experimentaldaemon to test on it.
The end goal being to remove the
experimentalbuilds.Signed-off-by: Vincent Demeester vincent@sbr.pm