Skip to content

Migrate test-integration-cli experimental macvlan test to integration#36697

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vdemeester:network-macvlan-test-migration
Mar 28, 2018
Merged

Migrate test-integration-cli experimental macvlan test to integration#36697
thaJeztah merged 1 commit intomoby:masterfrom
vdemeester:network-macvlan-test-migration

Conversation

@vdemeester
Copy link
Copy Markdown
Member

@vdemeester vdemeester commented Mar 26, 2018 •
edited
Loading

All Macvlan related test on DockerSuite and DockerNetworkSuite
are migrated to macvlan_test.go.

Also, as macvlan seems to be out of experimental, this removes
the skip when the run is not experimental (and doesn't start a
daemon with experimental either).

The end goal being to remove the experimental builds.

🦁

Signed-off-by: Vincent Demeester vincent@sbr.pm

@vdemeester vdemeester force-pushed the network-macvlan-test-migration branch from 7383de6 to c50530e Compare March 26, 2018 13:18
@vdemeester
Copy link
Copy Markdown
Member Author

vdemeester commented Mar 26, 2018 •
edited
Loading 

13:44:53 === RUN   TestDockerNetworkMacvlanPersistance
13:44:53 --- SKIP: TestDockerNetworkMacvlanPersistance (0.00s)
13:44:53 	macvlan_test.go:25: macvlanKernelSupport(): Kernel doesn't support macvlan
13:44:53 === RUN   TestDockerNetworkMacvlanOverlapParent
13:44:53 --- SKIP: TestDockerNetworkMacvlanOverlapParent (0.00s)
13:44:53 	macvlan_test.go:52: macvlanKernelSupport(): Kernel doesn't support macvlan
13:44:53 === RUN   TestDockerNetworkMacvlanSubinterface
13:44:53 --- SKIP: TestDockerNetworkMacvlanSubinterface (0.00s)
13:44:53 	macvlan_test.go:92: macvlanKernelSupport(): Kernel doesn't support macvlan
13:44:53 === RUN   TestDockerNetworkMacvlanBridgeNilParent
13:44:53 --- SKIP: TestDockerNetworkMacvlanBridgeNilParent (0.00s)
13:44:53 	macvlan_test.go:126: macvlanKernelSupport(): Kernel doesn't support macvlan
13:44:53 === RUN   TestDockerNetworkMacvlanBridgeInternal
13:44:53 --- SKIP: TestDockerNetworkMacvlanBridgeInternal (0.00s)
13:44:53 	macvlan_test.go:150: macvlanKernelSupport(): Kernel doesn't support macvlan
13:44:53 === RUN   TestDockerNetworkMacvlanMultiSubnet
13:44:53 --- SKIP: TestDockerNetworkMacvlanMultiSubnet (0.00s)
13:44:53 	macvlan_test.go:179: Temporarily skipping while investigating sporadic v6 CI issues

I though janky would have a kernel that supports that.. 🤕

EDIT: nevermind, I'm just dumb 😹

@vdemeester vdemeester force-pushed the network-macvlan-test-migration branch from c50530e to b71f119 Compare March 26, 2018 14:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b6a7d02). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36697   +/-   ##
=========================================
  Coverage          ?   34.96%           
=========================================
  Files             ?      613           
  Lines             ?    45559           
  Branches          ?        0           
=========================================
  Hits              ?    15928           
  Misses            ?    27542           
  Partials          ?     2089

@vdemeester vdemeester force-pushed the network-macvlan-test-migration branch from b71f119 to 3a9f729 Compare March 27, 2018 15:55
@vdemeester vdemeester force-pushed the network-macvlan-test-migration branch from 3a9f729 to 96f7d92 Compare March 28, 2018 07:42
@vdemeester
Migrate test-integration-cli experimental macvlan test to integration
ef5bc60 
All `Macvlan` related test on `DockerSuite` and `DockerNetworkSuite`
are migrated to `macvlan_test.go`.

Also, as `macvlan` seems to be out of experimental, this removes
the *skip* when the run is not experimental (and doesn't start a
daemon with experimental either).

The end goal being to remove the `experimental` builds.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the network-macvlan-test-migration branch from 96f7d92 to ef5bc60 Compare March 28, 2018 08:47
@vdemeester
Copy link
Copy Markdown
Member Author

vdemeester commented Mar 28, 2018

Updated (and should be green) 👼

thaJeztah
thaJeztah approved these changes Mar 28, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ping @fcrisciani @selansen PTAL

fcrisciani
fcrisciani approved these changes Mar 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester mentioned this pull request Mar 28, 2018
Merged
@thaJeztah thaJeztah merged commit 3858865 into moby:master Mar 28, 2018
@vdemeester vdemeester deleted the network-macvlan-test-migration branch March 28, 2018 15:56
@selansen
Copy link
Copy Markdown
Contributor

selansen commented Mar 28, 2018

LGTM

@vdemeester vdemeester mentioned this pull request Apr 5, 2018
Open
17 tasks
@thaJeztah thaJeztah mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@dnephin dnephin Awaiting requested review from dnephin

@mavenugo mavenugo Awaiting requested review from mavenugo

@yongtang yongtang Awaiting requested review from yongtang

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83

+1 more reviewer

@fcrisciani fcrisciani fcrisciani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vdemeester @selansen @thaJeztah @fcrisciani @GordonTheTurtle