Merged
Conversation
Sorting by mount point length can be implemented in a more straightforward fashion since Go 1.8 introduced sort.Slice() with an ability to provide a less() function in place. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
tonistiigi
approved these changes
Mar 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #36506 +/- ##
==========================================
+ Coverage 34.64% 34.67% +0.03%
==========================================
Files 613 612 -1
Lines 45404 45400 -4
==========================================
+ Hits 15730 15743 +13
+ Misses 27614 27599 -15
+ Partials 2060 2058 -2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting by mount point length can be implemented in a more straightforward fashion since Go 1.8 introduced
sort.Slice()with an ability to provide aless()function in place.(this used to be part of #36091; singled out for easier review)