Split binary installers/commit scripts#36336
Conversation
|
What do you think about the proposal in #35937 ? I don't think it would change much here, it would just be a rename of I guess many of these scripts would also go into a |
hack/dockerfile/binaries-commits
Outdated
There was a problem hiding this comment.
Is this still used somewhere? Could we remove it?
There was a problem hiding this comment.
I'll test... I think I originally removed it and then added it back in because something broke... been awhile now.
There was a problem hiding this comment.
It's used in the go autogen stuff.
There was a problem hiding this comment.
Could autogen source the files it needs directly?
|
@dnephin I'm all for reorganizing. |
There was a problem hiding this comment.
Should we include the optimisations in this PR? #35100 (comment)
There was a problem hiding this comment.
I'd rather get this in, then update it with optimizations.
There was a problem hiding this comment.
We should include the comments from the binary-commits in these files (i.e. update vendor.conf if needed, and vice-versa)
Also (mentioned that somewhere else) would be nice to have a utility to automatically fetch the git-commit from the vendor.conf
There was a problem hiding this comment.
Updated to add the comments.
The fetch commit thing shouldn't be too hard, but I'd prefer to do it separately.
26f712d to
5eb6aff
Compare
Codecov Report
@@ Coverage Diff @@
## master #36336 +/- ##
==========================================
+ Coverage 34.31% 34.32% +0.01%
==========================================
Files 609 609
Lines 45309 45309
==========================================
+ Hits 15547 15553 +6
- Misses 27755 27756 +1
+ Partials 2007 2000 -7 |
|
All updated. |
Dockerfile.e2e
Outdated
There was a problem hiding this comment.
Do you recall why you changed this? Should this be /. (slash-dot)? https://docs.docker.com/engine/reference/commandline/cp/#extended-description
5eb6aff to
6c7277c
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but would like more people to have a look 😄
Originally I worked on this for the multi-stage build Dockerfile changes. Decided to split this out as we are still waiting for multi-stage to be available on CI and rebasing these is pretty annoying. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
6c7277c to
b529d1b
Compare
|
Removed |
Originally I worked on this for the multi-stage build Dockerfile
changes. Decided to split this out as we are still waiting for
multi-stage to be available on CI and rebasing these is pretty annoying