Sync binary commits with vndr#36335
Merged
vdemeester merged 3 commits intomoby:masterfrom Feb 16, 2018
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The BurntSushi/toml code is now re-licensed as MIT. While the vendored package was already updated, the tomlv binary used was still using the old license type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Feb 16, 2018
Member
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM BTW do we plan to migrate to go dep? (after go 1.1x?)
Member
Author
|
@AkihiroSuda I think @tiborvass was looking at that as an option |
Codecov Report
@@ Coverage Diff @@
## master #36335 +/- ##
=========================================
Coverage ? 34.22%
=========================================
Files ? 609
Lines ? 45267
Branches ? 0
=========================================
Hits ? 15493
Misses ? 27821
Partials ? 1953 |
4 tasks
Member
I think we should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly for "hygiene";
userland-proxy) for libnetwork: moby/libnetwork@fcf1c3b...20dd462ping @vdemeester @AkihiroSuda PTAL