Skip to content

Rename integration/util to integration/internal #36265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdemeester merged 1 commit into from
Feb 10, 2018
Merged

Rename integration/util to integration/internal #36265

vdemeester merged 1 commit into from
Feb 10, 2018

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 9, 2018

Both names have no real sense, but one allows to make sure these packages
aren't used outside of integration.

😝 🌵

Signed-off-by: Vincent Demeester vincent@sbr.pm

dnephin
dnephin approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester mentioned this pull request Feb 9, 2018
Merged
@vdemeester vdemeester force-pushed the rename-integration-util-to-internal branch from 2d8d366 to 62d9e22 Compare February 9, 2018 18:46
@vdemeester vdemeester requested a review from tianon as a code owner February 9, 2018 18:46
yongtang
yongtang approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang
Copy link
Member

yongtang commented Feb 9, 2018

@vdemeester There seems to be one conflict:

22:05:17 integration/container/inspect_test.go:12:2:warning: could not import github.com/docker/docker/integration/util/request (cannot find package "github.com/docker/docker/integration/util/request" in any of: (gosimple)
22:05:17 Build step 'Execute shell' marked build as failure

Can you take a look?

thaJeztah
thaJeztah approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if CI is fixed)

@vdemeester
Rename integration/util to integration/internal
af306d1 
Both names have no real sense, but one allows to make sure these packages
aren't used outside of `integration`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the rename-integration-util-to-internal branch from 62d9e22 to af306d1 Compare February 10, 2018 08:16
@vdemeester
Copy link
Member Author

vdemeester commented Feb 10, 2018

rebased 😉

@vdemeester vdemeester merged commit 3053006 into moby:master Feb 10, 2018
@vdemeester vdemeester deleted the rename-integration-util-to-internal branch February 10, 2018 13:25
@yongtang yongtang mentioned this pull request Feb 11, 2018
Merged
This was referenced Feb 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

+2 more reviewers

@dnephin dnephin dnephin approved these changes

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vdemeester @yongtang @dnephin @thaJeztah @GordonTheTurtle