Skip to content

Remove support for referencing images by 'repository:shortid' #35790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Dec 15, 2017
Merged

Remove support for referencing images by 'repository:shortid' #35790

thaJeztah merged 1 commit into from
Dec 15, 2017

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 13, 2017

The repository:shortid syntax for referencing images is very little used, collides with with tag references can be confused with digest references.

The repository:shortid notation was deprecated in Docker 1.13 through
5fc7159 (#27207), and scheduled for removal in Docker 17.12.

This patch removes the support for this notation.

- Description for the changelog

* Remove support for referencing images through `repository:short-id`. Support for this notation was deprecated in Docker 1.13, and scheduled for removal in Docker 17.12 []()

- A picture of a cute animal (not mandatory but encouraged)

centipede-020

(image source: https://csolsqs.com/centipede/centipede-020.jpg)

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 13, 2017

ping @tonistiigi @dmcgowan PTAL

@thaJeztah thaJeztah mentioned this pull request Dec 13, 2017
Merged
@tonistiigi
Copy link
Member

tonistiigi commented Dec 13, 2017

LGTM

vieux
vieux approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@vieux vieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Contributor

andrewhsu commented Dec 14, 2017

I see at least 1 failure on experimental and janky:

FAIL: docker_cli_tag_test.go:145: DockerSuite.TestTagTruncationAmbiguity

docker_cli_tag_test.go:152:
    id := inspectField(c, truncatedTag, "Id")
docker_utils_test.go:110:
    c.Assert(err, check.IsNil)
... value *errors.errorString = &errors.errorString{s:"failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n"} ("failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n")

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 14, 2017

Darn, I couldn't find a test for this old behaviour, but looks like there was one; fixing

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 14, 2017

Updated, removed the test

@thaJeztah
Remove support for referencing images by 'repository:shortid'
a942c92 
The `repository:shortid` syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The `repository:shortid` notation was deprecated in Docker 1.13 through
5fc7159, and scheduled for removal
in Docker 17.12.

This patch removes the support for this notation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vdemeester
vdemeester approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah thaJeztah merged commit 6796e74 into moby:master Dec 15, 2017
@thaJeztah thaJeztah deleted the image-shortid branch December 15, 2017 09:34
@thaJeztah thaJeztah mentioned this pull request Dec 15, 2017
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 15, 2017

💯 ✖️ 5️⃣ 🎉

@lowenna lowenna mentioned this pull request Jan 9, 2018
Merged
@thaJeztah thaJeztah mentioned this pull request Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnephin dnephin Awaiting requested review from dnephin

2 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@vieux vieux vieux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/distribution Image Distribution area/images Image Distribution impact/changelog impact/deprecation impact/documentation status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @tonistiigi @andrewhsu @vdemeester @vieux @GordonTheTurtle