Add timeouts for volume plugin ops#35441
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 17, 2018
Merged
Conversation
4ed3fd9 to
3f310ed
Compare
3f310ed to
c765bb4
Compare
tonistiigi
reviewed
Dec 6, 2017
pkg/plugins/client.go
Outdated
Member
There was a problem hiding this comment.
if this function retries with backoff then it shouldn't probably reuse the context as just waiting for a backoff will cause this context to close
d80336e to
130dde7
Compare
Member
|
@tonistiigi looks like the PR was updated PTAL |
tonistiigi
reviewed
Dec 8, 2017
pkg/plugins/client.go
Outdated
Member
There was a problem hiding this comment.
Is it documented that request context does not have any effect after Do returns? Technically the request is still active at this point.
c58f11f to
f1cf97e
Compare
Member
Author
|
Ok, I've updated this. PTAL. |
tonistiigi
approved these changes
Jan 16, 2018
pkg/plugins/client.go
Outdated
Member
There was a problem hiding this comment.
nit: why is this inside the loop?
Member
Author
There was a problem hiding this comment.
Ah, from prior implementation attempt. Will fix.
This protects the daemon from volume plugins that are slow or deadlocked. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
f1cf97e to
b15f8d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This protects the daemon from volume plugins that are slow or
deadlocked.
These are some fairly conservative timeouts, but I still worry that they could be problematic.
ping @tonistiigi