[integration-cli] fix flaky raft test#35173
Merged
yongtang merged 1 commit intomoby:masterfrom Oct 12, 2017
Merged
Conversation
Fixes previously flaky TestAPISwarmRaftQuorum. In the test we are shutting down 2 of 3 nodes, all of which are managers. When this happens the remaining node prepares to step down from being a leader because there is no longer an active quorum. This test was written before that change was implemented, and assumes that the remaining node can still handle requests to create a service (it can't) There was further flakiness depending on whether or not the node has stepped down or was in the process of doing so. Fix this by waiting for the node to completely step down and checking to see if it errors out like it should. Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>
aaronlehmann
approved these changes
Oct 12, 2017
Member
|
Thanks Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #34988
In the test we are shutting down 2 of 3 nodes, all of which are managers.
When this happens the remaining node prepares to step down from being
a leader because there is no longer an active quorum. This test was
written before that change was implemented, and assumes that the
remaining node can still handle requests to create a service.
There was further flakiness depending on whether or not the node has
stepped down or was in the process of doing so. Fix this by waiting
for the node to completely step down and checking to see if it errors
out like it should.
Signed-off-by: Christopher Jones tophj@linux.vnet.ibm.com