Stop filtering Windows manifest lists by version#35117
Merged
lowenna merged 1 commit intomoby:masterfrom Oct 10, 2017
Merged
Conversation
Signed-off-by: John Stephens <johnstep@docker.com>
lowenna
approved these changes
Oct 8, 2017
Member
lowenna
left a comment
There was a problem hiding this comment.
LGTM from code inspection. I’ll try to find time to verify this evening or tomorrow.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Stephens johnstep@docker.com
Stop excluding incompatible Windows versions because it is possible to run some with Hyper-V isolation. However, still move compatible versions to the top, since they are preferred, but preserve the order if no compatible versions are found. More work is required to finalize the policy; for example, versions greater than the host should probably be excluded, even if just the UBR (Update Build Release) is higher.