LCOW - Change platform parser directive to FROM statement flag#35089
Merged
johnstep merged 7 commits intomoby:masterfrom Mar 26, 2018
Merged
LCOW - Change platform parser directive to FROM statement flag#35089johnstep merged 7 commits intomoby:masterfrom
johnstep merged 7 commits intomoby:masterfrom
Conversation
2177ec0 to
282e072
Compare
Member
|
@stevvooe this is one of the sort of things you had in mind when you created containerd/containerd#1403, right? |
Contributor
|
@tianon Yes. We need to massage that package to meet these use cases. |
217be81 to
b60609f
Compare
b60609f to
63cd7cc
Compare
63cd7cc to
abf631a
Compare
Member
Author
abf631a to
c0ab585
Compare
Member
Author
|
Rebased on #34859 again to keep fresh |
c0ab585 to
a16c1f6
Compare
Member
Author
|
@johnstep @tonistiigi @stevvooe PTAL. I've now rebased it after #34859 was merged and tidied it up. Ready for review. |
c4c26be to
cb8355e
Compare
7d8a4a4 to
b2d34ce
Compare
added 7 commits
March 19, 2018 14:29
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
fb82b3f to
1442905
Compare
lowenna
pushed a commit
to microsoft/docker
that referenced
this pull request
Mar 19, 2018
Signed-off-by: John Howard <jhoward@microsoft.com> Addresses moby#35089 (comment). This change enables the daemon to automatically select an image under LCOW that can be used if the API doesn't specify an explicit platform. For example: FROM supertest2014/nyan ADD Dockerfile / And docker build . will download the linux image (not a multi-manifest image) And similarly docker pull ubuntu will match linux/amd64
Member
|
LGTM |
johnstep
reviewed
Mar 26, 2018
| return nil, err | ||
| } | ||
|
|
||
| flPlatform := req.flags.AddString("platform", "") |
Member
There was a problem hiding this comment.
Nit: I am not a fan of this Hungarian-style notation, preferring platform or platformFlag. There is a precedent for the fl prefix in the builder, so it's okay, but I think it should be cleaned up eventually. :)
lowenna
pushed a commit
to microsoft/docker
that referenced
this pull request
Mar 27, 2018
Signed-off-by: John Howard <jhoward@microsoft.com> Addresses moby#35089 (comment). This change enables the daemon to automatically select an image under LCOW that can be used if the API doesn't specify an explicit platform. For example: FROM supertest2014/nyan ADD Dockerfile / And docker build . will download the linux image (not a multi-manifest image) And similarly docker pull ubuntu will match linux/amd64
tonistiigi
pushed a commit
to tonistiigi/docker
that referenced
this pull request
Jun 26, 2018
Signed-off-by: John Howard <jhoward@microsoft.com> Addresses moby#35089 (comment). This change enables the daemon to automatically select an image under LCOW that can be used if the API doesn't specify an explicit platform. For example: FROM supertest2014/nyan ADD Dockerfile / And docker build . will download the linux image (not a multi-manifest image) And similarly docker pull ubuntu will match linux/amd64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
# platform=....parser directive, and adds--platformas a flag to theFROMstatement instead. This is one of the action items from the F2F in SF in August 2017, and the document described in #34617. It's a direct follow-on to #34859 which is now merged in master