Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Looks like #34424 still depends on changes in swarm kit, so we should not merge in a hurry (i.e., if there's no changes to the API, the next Docker release just will use the same API version as 17.09) |
Member
Author
|
temporarily renaming to [WIP] because 17.10 will be cut off soon, and I don't want to bump the version if there are no changes |
Member
Author
|
Opened #34988 for the flaky test |
thaJeztah
commented
Sep 26, 2017
Member
Author
thaJeztah
left a comment
There was a problem hiding this comment.
I'll merge this one to unblock other PR's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating this to unblock #34424
ping @simonferquel @vdemeester @dnephin PTAL