Re-enable some conversion for darwin-amd64 platform#34745
Merged
yongtang merged 1 commit intomoby:masterfrom Sep 6, 2017
Merged
Re-enable some conversion for darwin-amd64 platform#34745yongtang merged 1 commit intomoby:masterfrom
yongtang merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
97b913c to
7c9e64a
Compare
|
+1. Closes #34726 |
Member
|
All tests passed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With introduction of the convert linter, some convertion that are mandatory for some platforms supported by the cli (but not the daemon) have been erronously removed. Especially, on darwin-amd64, stat_t.Rdev is an int32 and cannot be converted implicitly to uint64.
- What I did
Re-enabled convertion for this case
- How I did it
Very simple code change
- How to verify it
Vendor this PR in the CLI project and cross compile