force inspect test format by vieux · Pull Request #34707 · moby/moby

vieux · 2017-09-01T19:17:17Z

depending of the docker cli version used, sometimes the result will be 5e+08 sometimes it will be
500000000

This update the test to force the use of a common output.

dnephin

I guess this works, so would something like this which removes the dependency on the client:

inspect, err := client.ContainerInspect(context.Background(), "test")
c.Assert(err, checker.IsNil)
c.Assert(inspect.HostConfig.NanoCPUs, checker.Equals, 500000000)

seemethere · 2017-09-01T20:27:05Z

Kicked off a build here: https://jenkins.dockerproject.org/job/docker-integration-tests/111/

seemethere · 2017-09-01T21:17:08Z

@vieux Tests still failed: https://jenkins.dockerproject.org/job/docker-integration-tests/111/execution/node/272/log/

00:46:28.249 ----------------------------------------------------------------------
00:46:28.249 FAIL: docker_cli_run_unix_test.go:1558: DockerSuite.TestRunWithNanoCPUs
00:46:28.249 
00:46:28.249 docker_cli_run_unix_test.go:1566:
00:46:28.249     cli.InspectCmd(c, "test", cli.Format("HostConfig.NanoCpus | printf \"%f\"")).Assert(c, icmd.Expected{
00:46:28.249         Out: "500000000.000000",
00:46:28.249     })
00:46:28.249 /go/src/github.com/docker/docker/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
00:46:28.249     t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
00:46:28.249 ... Error: at cli.go:43 - 
00:46:28.249 Command:  /usr/local/cli/docker inspect --format {{HostConfig.NanoCpus | printf "%f"}} test
00:46:28.249 ExitCode: 64
00:46:28.249 Error:    exit status 64
00:46:28.249 Stdout:   
00:46:28.249 Stderr:   Template parsing error: template: :1: function "HostConfig" not defined
00:46:28.249 
00:46:28.249 
00:46:28.249 Failures:
00:46:28.249 ExitCode was 64 expected 0
00:46:28.249 Expected no error
00:46:28.249 
00:46:28.249 
00:46:28.815 
00:46:28.815 ----------------------------------------------------------------------

00:48:11.634 ----------------------------------------------------------------------
00:48:11.634 FAIL: docker_cli_update_unix_test.go:288: DockerSuite.TestUpdateWithNanoCPUs
00:48:11.634 
00:48:11.634 docker_cli_update_unix_test.go:300:
00:48:11.634     cli.InspectCmd(c, "top", cli.Format("HostConfig.NanoCpus | printf \"%f\"")).Assert(c, icmd.Expected{
00:48:11.634         Out: "500000000.000000",
00:48:11.634     })
00:48:11.634 /go/src/github.com/docker/docker/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
00:48:11.634     t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
00:48:11.634 ... Error: at cli.go:43 - 
00:48:11.634 Command:  /usr/local/cli/docker inspect --format {{HostConfig.NanoCpus | printf "%f"}} top
00:48:11.634 ExitCode: 64
00:48:11.634 Error:    exit status 64
00:48:11.634 Stdout:   
00:48:11.634 Stderr:   Template parsing error: template: :1: function "HostConfig" not defined
00:48:11.634 
00:48:11.634 
00:48:11.634 Failures:
00:48:11.634 ExitCode was 64 expected 0
00:48:11.634 Expected no error
00:48:11.634 
00:48:11.634 
00:48:12.199 
00:48:12.199 ----------------------------------------------------------------------

vieux · 2017-09-01T21:34:51Z

@seemethere sorry I made a silly mistake, can you kick it again ?

seemethere · 2017-09-01T21:36:11Z

Kicked again https://jenkins.dockerproject.org/job/docker-integration-tests/113/

boaz0

👍 LGTM

vieux · 2017-09-04T23:24:55Z

I rebased using @dnephin's solution.

vdemeester · 2017-09-05T07:38:32Z

@vieux compilation error

23:44:43 integration-cli/docker_cli_run_unix_test.go:1567: undefined: client in client.ContainerInspect
23:44:43 integration-cli/docker_cli_run_unix_test.go:1576: no new variables on left side of :=
23:44:43 integration-cli/docker_cli_update_unix_test.go:299: undefined: client in client.ContainerInspect
23:44:43 integration-cli/docker_cli_update_unix_test.go:308: no new variables on left side of :=
23:44:43 integration-cli/docker_cli_update_unix_test.go:313: undefined: client in client.ContainerInspect

Signed-off-by: Victor Vieux <victorvieux@gmail.com>

andrewhsu · 2017-09-05T17:00:10Z

@vieux new build started: https://jenkins.dockerproject.org/job/docker-integration-tests/120/

vieux · 2017-09-05T17:56:31Z

@andrewhsu looks like it is indeed fixing tests in docker-ce

@dnephin can you review once more please ?

seemethere · 2017-09-05T18:09:15Z

It indeed does look like it fixes the tests! We're down to 3.

❯ bash ~/scripts/check_failures.sh https://jenkins.dockerproject.org/job/docker-integration-tests/120/consoleText
FOR: https://jenkins.dockerproject.org/job/docker-integration-tests/120/consoleText

Passed (thought would fail):
DockerSuite.TestRunWithNanoCPUs
DockerSuite.TestUpdateWithNanoCPUs
DockerSwarmSuite.TestServiceLogs
DockerSwarmSuite.TestSwarmNetworkPluginV2
DockerSwarmSuite.TestSwarmServicePsMultipleServiceIDs

Failed (should fail)
DockerSuite.TestRmiContainerImageNotFound
DockerSuite.TestRmiImageIDForceWithRunningContainersAndMultipleTags
DockerSuite.TestRunAttachDetachFromInvalidFlag

Failed (thought would pass):

seemethere

LGTM

dnephin

LGTM

vdemeester

LGTM 🦁

vieux requested review from dnephin and vdemeester as code owners September 1, 2017 19:17

GordonTheTurtle added the status/0-triage label Sep 1, 2017

dnephin mentioned this pull request Sep 1, 2017

[Checklist] Move integration-cli tests to API tests #34623

Closed

8 tasks

vieux force-pushed the force_format branch from da17a30 to 728548f Compare September 1, 2017 19:19

dnephin approved these changes Sep 1, 2017

View reviewed changes

vieux force-pushed the force_format branch from 728548f to ab39703 Compare September 1, 2017 21:34

boaz0 approved these changes Sep 4, 2017

View reviewed changes

vieux force-pushed the force_format branch 2 times, most recently from 5ccd2de to 6a1bd65 Compare September 4, 2017 23:24

vieux force-pushed the force_format branch 2 times, most recently from 37373a1 to 09e2103 Compare September 5, 2017 08:16

vieux added rebuild/z status/2-code-review and removed status/0-triage labels Sep 5, 2017

GordonTheTurtle removed the rebuild/z label Sep 5, 2017

force inspect test format

8e6567c

Signed-off-by: Victor Vieux <victorvieux@gmail.com>

vieux force-pushed the force_format branch from 09e2103 to 8e6567c Compare September 5, 2017 15:31

vieux added the rebuild/windowsRS1 label Sep 5, 2017

GordonTheTurtle removed the rebuild/windowsRS1 label Sep 5, 2017

seemethere approved these changes Sep 5, 2017

View reviewed changes

vdemeester added the rebuild/windowsRS1 label Sep 5, 2017

GordonTheTurtle removed the rebuild/windowsRS1 label Sep 5, 2017

dnephin approved these changes Sep 5, 2017

View reviewed changes

vdemeester approved these changes Sep 5, 2017

View reviewed changes

vieux merged commit d7b4c7e into moby:master Sep 5, 2017

vieux deleted the force_format branch September 5, 2017 20:35

vieux mentioned this pull request Sep 5, 2017

[17.09] backport: force inspect test format docker-archive/docker-ce#220

Merged

thaJeztah mentioned this pull request Sep 10, 2022

Flaky test: TestRunAttachDetachFromInvalidFlag #44128

Open

Conversation

vieux commented Sep 1, 2017

Uh oh!

dnephin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seemethere commented Sep 1, 2017

Uh oh!

seemethere commented Sep 1, 2017

Uh oh!

vieux commented Sep 1, 2017

Uh oh!

seemethere commented Sep 1, 2017 • edited by vieux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boaz0 left a comment

Choose a reason for hiding this comment

Uh oh!

vieux commented Sep 4, 2017

Uh oh!

vdemeester commented Sep 5, 2017

Uh oh!

andrewhsu commented Sep 5, 2017

Uh oh!

vieux commented Sep 5, 2017

Uh oh!

seemethere commented Sep 5, 2017

Uh oh!

seemethere left a comment

Choose a reason for hiding this comment

Uh oh!

dnephin left a comment

Choose a reason for hiding this comment

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dnephin left a comment •

edited

Loading

seemethere commented Sep 1, 2017 •

edited by vieux

Loading