Merged
Conversation
Member
Author
|
@johnstep too :) |
Signed-off-by: John Howard <jhoward@microsoft.com>
00aef75 to
7b9a8f4
Compare
tonistiigi
reviewed
Aug 22, 2017
| imagePlatform := runtime.GOOS | ||
| id := image.IDFromDigest(digest) | ||
| for platform := range daemon.stores { | ||
| if img, err := daemon.stores[platform].imageStore.Get(id); err == nil { |
Member
There was a problem hiding this comment.
imageStore does not need to be duplicated either as it only contains the config json. Only layerStore is platform specific.
Member
Author
There was a problem hiding this comment.
@tonistiigi Sure, let me capture that in the document as the follow-up to last week (almost complete and ready to share for discussion - delayed as OOF) and do as a follow-up PR.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
@tonistiigi @stevvooe @dmcgowan @mlaventure As per offline discussion (larger doc to follow, but this is one of the easier non-contentious pieces), this restructures the daemon back to how it was so that the reference (tag) store is global. This means that once the Windows daemon is able to run in dual LCOW/WCOW mode again, it will not be possible to have
image:tagas both a Windows and a Linux image.