[Proposal] Document testing guidelines#34407
Merged
tiborvass merged 1 commit intomoby:masterfrom Aug 17, 2017
Merged
Conversation
Signed-off-by: Daniel Nephin <dnephin@docker.com>
AkihiroSuda
reviewed
Aug 5, 2017
| To run the integration test suite: | ||
|
|
||
| ``` | ||
| make test-integration |
Member
Author
There was a problem hiding this comment.
It is now, yes, but this should change soon. This doc is for the "new way" so I don't think it should document test-integration-cli
Member
|
ping @vdemeester @tiborvass @vieux |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #32866 and Evolution of testing @moby
I think we should have a document with testing guidelines of when to write a unit test vs an integration test, and the style for each.
Related:
docker/clitest-integrationtarget #34000 - PR to implement some of these changes