Closed
Conversation
Signed-off-by: John Howard <jhoward@microsoft.com> This removes all the `// TODO @jhowardmsft LCOW Support:....` from the builder. It adds `platform` to the build API as per the epic at moby#33850
This was referenced Aug 4, 2017
Member
Author
|
@johnstep FYI |
Member
|
Do we really need this parameter? In most cases we can infer this from the base image, right? If the base image is multi-platform then we need some way in the dockerfile to specify which platform we're targeting. I believe I saw a suggestion from @tonistiigi about that. Maybe: Is that not an option? |
Member
Author
|
@dnephin I had to put a stake in the ground somewhere to start that discusssion. Both are doable, although a parser directive is slightly more easy on implementation. Let's discuss the semantics in #33854 leaving this PR for the implementation of it. @PatrickLang FYI |
stevvooe
reviewed
Aug 17, 2017
| ImageID() string | ||
| RunConfig() *container.Config | ||
| MarshalJSON() ([]byte, error) | ||
| Platform() string |
Contributor
There was a problem hiding this comment.
Let's use the full, OCI-style platform descriptor for this.
Member
Author
|
Closing. Replaced by #34642 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
This removes all the
// TODO @jhowardmsft LCOW Support:....from the builder. It addsplatformto the build API as per the epic at #33850. Will open the client API to match this shortly.