Disable legacy (v1) registries by default#33629
Merged
mlaventure merged 2 commits intomoby:masterfrom Jun 12, 2017
Merged
Conversation
40 tasks
a4d5b48 to
7b596ae
Compare
Member
Author
|
Found some tests that need updating;
|
7b596ae to
6dc304b
Compare
Deprecation of interacting with v1 registries was started in docker 1.8.3, which added a `--disable-legacy-registry` flag. This option was anounced to be the default starting with docker 17.06, and v1 registries completely removed in docker 17.12. This patch updates the default, and disables interaction with v1 registres by default. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
6dc304b to
2b8f0ee
Compare
Member
Author
|
Tests were updated; all green now |
|
LGTM Not sure about doing this after the freeze, but not I'm not going to block this. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation of interacting with v1 registries was started in docker 1.8.3, which added a
--disable-legacy-registryflag.This option was announced to be the default starting with docker 17.06, and v1 registries completely removed in docker 17.12.
This patch updates the default, and disables interaction with v1 registres by default.
ping @dmcgowan @aaronlehmann