@aaronlehmann I've addressed your issues, fixed vendors (I think) and compilation.
Should I also update api/swagger.yaml ?

@aaronlehmann I've create a ResourceObject object to encapsulate NanoCPUs and MemoryBytes which were hardcoded in every structures.

I'm not really sure about the choice of name but because there already exists a Resources object I don't have any other suggestions. Do you have some idea ?

Thanks!

@aaronlehmann @stevvooe @ehazlett @tonistiigi PTAL :)
Thanks!

I wonder how this impacts #33575 by @cpuguy83

@tiborvass I gave the plugin PR a quick look and it seems to me that it wouldn't impact it :)
Though I think that the current model would let your plugin request Generic resources which I think is something that seems reasonable ?

Agreed I don't think there is any impact.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "genericresource" git@github.com:RenaudWasTaken/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353767704
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@RenaudWasTaken I agree! Thank you!

@stevvooe once the PR gets accepted in swarmkit should I do a seperate PR to update moby dependencies or should I update the deps in this PR ?

@RenaudWasTaken Whatever is easiest for you!

@stevvooe Rebased against master with the latests swarmkit revendoring

This looks pretty good to me.

The only concern I have is allowing the engine to define the resources (via the info endpoint as it does in in this PR) vs doing it at the node level.
By "concern" here, I mean I'm not sure which is the right approach, not necessarily that I think there's something wrong with it.

The only concern I have is allowing the engine to define the resources (via the info endpoint as it does in in this PR) vs doing it at the node level.

@cpuguy83 what do you mean by doing it at the node level ?

@RenaudWasTaken Sorry, for "node" level I mean on the swarm node object rather than the engine itself.

@cpuguy83 we discussed that with @aaronlehmann before so I'll be quoting him in #2090 :)

The current behavior for the existing resources (NanoCPUs and MemoryBytes) is that they get filled in by Describe (see agent/exec/dockerapi/executor.go for the dockerapi executor implementation). I think we should follow this with generic resources, so that they are consistent with the existing resources, and because it's an easy way to address the hotplug case (Describe is called periodically, and the node is updated dynamically based on the result).

and:

But once this is all integrated in Docker, I think the source of truth should be the SystemInfo call, not information passed through Node.

@cpuguy83 @stevvooe is there anything in this PR that needs to be changed ?

LGTM

CI is now green :)

@aaronlehmann @cpuguy83 what is the process to integrate in the CLI ?
It seems they don't rebase very often should I open an issue ?

@RenaudWasTaken Rebasing is done as needed. If you have changes that need to go into the CLI that require a bump of moby/moby, you can revendor in 1 commit and make your changes in a 2nd commit.