Merged
Conversation
Since this new version of the CLI resolves image digests for swarm services by default, and we do not want integration tests to talk to Docker Hub, update CLI tests to suppress this behavior. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
| DOCKERCLI_REPO=https://github.com/dperny/cli | ||
| DOCKERCLI_COMMIT=7230906e0e297999eb33da74e0279c5cf41a119e | ||
| DOCKERCLI_REPO=https://github.com/docker/cli | ||
| DOCKERCLI_COMMIT=3dfb8343b139d6342acfd9975d7f1068b5b1c3d3 |
Contributor
There was a problem hiding this comment.
Is there a reason this commit is not docker/cli master (eea4a38cd69d47ae6fb8fc02e9fdab0e23e2560e)? Seems like the last merge was also due for the code freeze.
Contributor
|
LGTM. I'm just checking if there are any EDIT: I think all instances are covered 👍 |
Contributor
|
LGTM for the git commit hash to use for |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this new version of the CLI resolves image digests for swarm services by default, and we do not want integration tests to talk to Docker Hub, update CLI tests to suppress this behavior.
cc @andrewhsu @aluzzardi @nishanttotla