Rename integration-cli to integration…#33124
Closed
vdemeester wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
Member
|
There's some other PR's that we'd like to have merged before 17.06 code freeze, but we can make this change after those are in 🤗 |
95bdc4e to
4f3c6b4
Compare
Member
Author
Definitely 😉 |
… and `test-integration-cli` to `test-integration`. These tests include more than `cli` integration tests and now that `cli` is no more in here (but in `docker/cli` it makes even less sense to keep that name. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
4f3c6b4 to
2c265e6
Compare
Member
|
windows failing |
Member
Author
This is to be expected for now, I would need to update the CI (but we'll wait a bit for that though) |
Member
Author
|
After discussing the subject in daily #moby-project, let's close this one for now, taking another note (issue/ml to come to discuss on the subject 😉) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and
test-integration-clitotest-integration. These testsinclude more than
cliintegration tests and now thatcliis nomore in here (but in
docker/cliit makes even less sense to keepthat name.
🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm