Prevent a non-zero NanoCPUs from setting a zero CPU.Count#32727
Prevent a non-zero NanoCPUs from setting a zero CPU.Count#32727tonistiigi merged 1 commit intomoby:masterfrom
Conversation
|
@darrenstahlmsft Hi Darren, I have two points there. I would appreciate if you can clarify them:
Could you provide details how I can do it?
|
When run in Debug mode, the daemon will print out this line when a container is started: Which includes: ProcessorMaximum is a value between 1 and 10000. This is what
It is the smallest value that Docker currently can pass, though HCS supports smaller. I can add a work item to my list to add more granular settings to Docker. Hyper-V containers can support |
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯
@darrenstahlmsft needs a rebase 👼
Signed-off-by: Darren Stahl <darst@microsoft.com>
0606a8e to
b3649f4
Compare
|
Rebased |
Unrelated failure. Is this fixed? |
Signed-off-by: Darren Stahl darst@microsoft.com
- What I did
Prevent a non-zero NanoCPUs from setting a zero CPU.Count
fixes #32014
- How I did it
If calculated cpuPercent is 0, set to 1.
- How to verify it
Create a container with
--cpus 0.01. Inspect the JSON blob sent to HCS, ensure that CpuMaximum is not 0.- Description for the changelog
Windows: Fix rounding error on small values of NanoCPUs