Shutdown leaks an error when the container was never started #31279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that sometimes tasks would end up in a rejected state when trying to update them quickly. The problem was that Shutdown could fail if called before the container was started. Instead of returning an error in this case, Shutdown should succeed. This allows tasks to progress to the "shutdown" state as expected. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Contributor
|
Looks good to me |
mavenugo
approved these changes
Feb 23, 2017
Contributor
|
LGTM. thanks @aaronlehmann |
Contributor
|
lgtm (not a maintainer) |
Contributor
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that sometimes tasks would end up in a rejected state when trying to update them quickly. The problem was that
Shutdowncould fail if called before the container was started. Instead of returning an error in this case,Shutdownshould succeed. This allows tasks to progress to the "shutdown" state as expected.This was part of #31108 that I'm extracting into its own PR.