plugingetter: Avoid all caps for constant declarations#29564
plugingetter: Avoid all caps for constant declarations#29564vdemeester merged 1 commit intomoby:masterfrom
Conversation
|
LGTM |
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐸
@aaronlehmann needs a rebase and vendoring 👼
|
Given the cyclic dependency issue, vendoring will have to be a two-stage effort. Are people okay with the original plan of vendoring a libnetwork fork in this PR, and then upstreaming the change once this is merged? |
|
@aaronlehmann I'm sad we have cyclic dependency issues (libnetwork and swarmkit at least right ?) and we might want to work to sort this out. But this should not block this PR so I'm fine with vendoring a libnetwork fork in that PR and have a follow-up. Could you update |
|
Might be better for libnetwork to just copy rather than deal with these cyclic issues, no? |
Go style calls for mixed caps instead of all caps: https://golang.org/doc/effective_go.html#mixed-caps Change LOOKUP, ACQUIRE, and RELEASE to Lookup, Acquire, and Release. This vendors a fork of libnetwork for now, to deal with a cyclic dependency issue. The change will be upstream to libnetwork once this is merged. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
110c604 to
4286001
Compare
|
Rebased and updated to vendor a temporary libnetwork fork. |
|
LGTM How is this used in |
|
@stevvooe libnetwork ultimately calls the driver APIs for any CNM events such as add-network, create-endpoint, etc... so it uses the plugin API to get the remote client to make that API invocation. @aaronlehmann @cpuguy83 I think it is better to keep the |
|
@mavenugo That is pretty unfortunate. Could we get these refactored so Either way, let's merge this. |
|
@aaronlehmann I'll let you update and re-vendor 👼 |
Go style calls for mixed caps instead of all caps:
https://golang.org/doc/effective_go.html#mixed-caps
Change
LOOKUP,ACQUIRE, andRELEASEtoLookup,Acquire, andRelease.I will rebase this after #29556 is merged.
Note that vendoring will be an issue because of cyclic dependencies between repositories. We should probably vendor a fork of libnetwork, and then upstream the change.