Merged
Conversation
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Member
Author
|
cc @mikedanese |
Member
|
ping @justincormack as well 👍 |
thaJeztah
reviewed
Dec 16, 2016
vendor.conf
Outdated
| golang.org/x/oauth2 2baa8a1b9338cf13d9eeb27696d761155fa480be | ||
| golang.org/x/oauth2 96382aa079b72d8c014eb0c50f6c223d1e6a2de0 | ||
| google.golang.org/api dc6d2353af16e2a2b0ff6986af051d473a4ed468 | ||
| # TODO: remove google.golang.org/cloud, which has been replaced by cloud.google.com/go |
Member
|
Looks like #25403 will be fixed by this as well, or are there more instances? |
AkihiroSuda
commented
Dec 16, 2016
| google.golang.org/api 3cc2e591b550923a2c5f0ab5a803feda924d5823 | ||
| cloud.google.com/go 9d965e63e8cceb1b5d7977a202f0fcb8866d6525 | ||
| github.com/googleapis/gax-go da06d194a00e19ce00d9011a13931c3f6f6887c7 | ||
| google.golang.org/genproto 9359a8d303c45e3212571b77610f1cefb0c6f3eb |
Member
Author
There was a problem hiding this comment.
Just note that I didn't use the latest genproto, so as to avoid undefined: grpc.SupportPackageIsVersion4 compilation error (messy! 😭)
Member
Author
There was a problem hiding this comment.
Also, google.golang.org/api is not the latest one, because vendoring the latest one was somehow messy
https://github.com/google/google-api-go-client/commits/master
Member
Author
|
@thaJeztah Yes, this PR will close #25403 as well |
justincormack
approved these changes
Dec 23, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Updated gcplogs deps.
The aim of this PR is to vendor golang/oauth2@96382aa for PR #29478, so as to fix issue #29344.
Also closes #25403
- How I did it
The first commit vendors the latest oauth2 and its deps.
So basically we only need the first commit.
However, the first commit is not enough because it vendors both
google.golang.org/cloudandcloud.google.com/go.So the second commit removes
google.golang.org/cloudand completely migrates tocloud.google.com/go.- How to verify it
docker run --log-driver=gcplogs ...- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)