Skip to content

cluster: Refuse swarm spec not named "default"#28914

Merged
thaJeztah merged 1 commit intomoby:masterfrom
aaronlehmann:cluster-object
Nov 29, 2016
Merged

cluster: Refuse swarm spec not named "default"#28914
thaJeztah merged 1 commit intomoby:masterfrom
aaronlehmann:cluster-object

Conversation

@aaronlehmann
Copy link
Copy Markdown

@aaronlehmann aaronlehmann commented Nov 29, 2016

If, using the API, a user submits an init request with a spec that has a
name other than "default", the engine will rename the "default" cluster
object. Some parts of swarmkit depend on having a cluster object named
"default". Reject any specs that use other names.

Fixes #28067

cc @tonistiigi

cluster: Refuse swarm spec not named "default"
9dba9e3 
If, using the API, a user submits an init request with a spec that has a
name other than "default", the engine will rename the "default" cluster
object. Some parts of swarmkit depend on having a cluster object named
"default". Reject any specs that use other names.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@aaronlehmann aaronlehmann added the priority/P1 Important: P1 issues are a top priority and a must-have for the next release. label Nov 29, 2016
@aaronlehmann aaronlehmann added this to the 1.13.0 milestone Nov 29, 2016
@aaronlehmann aaronlehmann mentioned this pull request Nov 29, 2016
Closed
@tonistiigi
Copy link
Copy Markdown
Member

tonistiigi commented Nov 29, 2016

LGTM

thaJeztah
thaJeztah approved these changes Nov 29, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Nov 29, 2016

Looks like Windows completed, but failed to notify GitHub;

02:48:55 [PostBuildScript] - Execution post build scripts.
02:48:55 Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
02:48:55 Finished: SUCCESS

@thaJeztah thaJeztah merged commit 82506fe into moby:master Nov 29, 2016
@aaronlehmann aaronlehmann deleted the cluster-object branch November 29, 2016 18:04
@vieux vieux mentioned this pull request Nov 29, 2016
Merged
@aaronlehmann aaronlehmann mentioned this pull request Dec 5, 2016
Merged
@yayuntian
Copy link
Copy Markdown

yayuntian commented Jun 14, 2017

LGTM

@yayuntian
Copy link
Copy Markdown

yayuntian commented Jun 14, 2017

But the RESTful API swarm update does not seem to do the operation check（check spec name）, will panic , and do not know when it will trigger this operation, the other hope to support fix swarm cluster name, there is this plan?

@aaronlehmann aaronlehmann mentioned this pull request Jun 21, 2017
Open
This was referenced Nov 9, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

priority/P1 Important: P1 issues are a top priority and a must-have for the next release. process/cherry-picked status/4-merge

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@aaronlehmann @tonistiigi @thaJeztah @yayuntian @vieux @GordonTheTurtle