change node ls and service ls api and docs#28192
Conversation
bda8059 to
9b5573f
Compare
|
/cc @thaJeztah @mstanleyjones |
There was a problem hiding this comment.
perhaps we should put this list in alphabetical order wdyt?
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! I left some comments/suggestions
There was a problem hiding this comment.
can you keep these blank lines? having an empty line makes it easier for people to distinguish the command that was run, and the output (even though it's not actually printed with a blank line)
There was a problem hiding this comment.
Can you add a blank line after here (see my explanation above)
There was a problem hiding this comment.
Can you add a blank line after here (see my explanation above)
There was a problem hiding this comment.
Maybe we should simplify, because this sentence, and instead add an example that shows a filter on (e.g.) label=somelabel=somevalue;
The `label` filter matches nodes based on engine labels. Node labels are currently not used for filtering.@vdemeester wdyt?
There was a problem hiding this comment.
We should fix that btw, as it's not very logical to have nodes filter on engine properties
3c7c564 to
dd66133
Compare
|
done, updated. PTAL @thaJeztah @vdemeester |
thaJeztah
left a comment
There was a problem hiding this comment.
So sorry, @allencloud my mistake, should've seen that during my first round
There was a problem hiding this comment.
oh! just recalled that in the new docs system, anchor tags need to be prepended with the document name (yup, it's annoying), so;
* [id](node_ls.md#ID)
* [label](node_ls.md#Label)
* [membership](node_ls.md#Membership)
* [name](node_ls.md#Name)
* [role](node_ls.md#Role)There was a problem hiding this comment.
Same here 😊
* [id](service_ls.md#ID)
* [label](service_ls.md#Label)
* [name](service_ls.md#Name)
mdlinville
left a comment
There was a problem hiding this comment.
LGTM with @thaJeztah's comments. Thanks!
dd66133 to
ceba47e
Compare
|
Oh, thanks for your advice. @thaJeztah @mstanleyjones |
|
Hold on, looks like the anchors should not have been changed to uppercase; anchors both on GitHub and docs.docker.com are lowercase ( |
Signed-off-by: allencloud <allen.sun@daocloud.io>
ceba47e to
48c3fce
Compare
|
Done, I did some improvement. But not sure if it is completed. @thaJeztah |
fixes #28165
There are some places in docs that maybe need improvements.
docker node ls;docker service lsdescriptionGET /servicesGET /nodesAll about filter description.
Also add more description about label filtering in
docker node ls. related to #27231Label filtering in
docker node lsis looking at engine labels rather than node labels.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: allencloud allen.sun@daocloud.io