opts/mount: add tmpfs-specific options#28150
Merged
vieux merged 1 commit intomoby:masterfrom Nov 10, 2016
Merged
Conversation
Member
Author
ff095c2 to
814dae0
Compare
stevvooe
reviewed
Nov 8, 2016
opts/mount.go
Outdated
Contributor
There was a problem hiding this comment.
Are there any cases where one would not pass these as octal?
Member
Author
There was a problem hiding this comment.
No.
Updated PR to use ParseUint(value, 8, ..) instead.
Linux tmpfs uses strtoul(..,8,.. ) as well: http://lxr.free-electrons.com/source/mm/shmem.c?v=4.8#L3440
stevvooe
reviewed
Nov 8, 2016
opts/mount_test.go
Outdated
Contributor
There was a problem hiding this comment.
Make sure to test a few variations of octal mode bits. For example, 0700 and 700 will be different.
Member
Author
There was a problem hiding this comment.
In Linux tmpfs 0700 is identical to 700.
http://lxr.free-electrons.com/source/mm/shmem.c?v=4.8#L3440
Updated the PR to test that.
added following options: * tmpfs-size * tmpfs-mode Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
814dae0 to
45ed6a7
Compare
Member
|
Design SGTM 🐸 |
Contributor
|
LGTM |
Member
|
ping @thaJeztah |
Member
|
Please wait with merging until #27967 is merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
added following options for
--mount(addendum to #26837):tmpfs-sizetmpfs-mode- How I did it
Updated opts/mount
- How to verify it
- Description for the changelog
opts/mount: add tmpfs-specific options
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp