Skip to content

Conversation

@yongtang
Copy link
Member

@yongtang yongtang commented Nov 4, 2016

This fix is a follow up for any additional docs update for PR #27958.

The original PR didn't mention the default value (and its meaning) in the API docs.

cc @thaJeztah for any additional needed updates.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase

This fix is a follow up for any additional docs update for PR 27958.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang yongtang force-pushed the 27958-docs-follow-up branch from 8daef1c to f82f8ee Compare November 5, 2016 03:19
@yongtang
Copy link
Member Author

yongtang commented Nov 5, 2016

Thanks @thaJeztah. The PR has been rebased.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit b814024 into moby:master Nov 7, 2016
@yongtang yongtang deleted the 27958-docs-follow-up branch November 7, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants