Add metrics docs to cli reference#27862
Conversation
ad4d32f to
7dc713c
Compare
There was a problem hiding this comment.
I don't know what your general approach to port allocation is, but if you don't have any particular preference I'd suggest grabbing a number off https://github.com/prometheus/prometheus/wiki/Default-port-allocations
This will help your users avoid clashes with other Prometheus exporters.
There was a problem hiding this comment.
This is just an example and if we set a default port we will register it with IANA ;)
There was a problem hiding this comment.
@thaJeztah do you just want to go ahead and register one?
There was a problem hiding this comment.
let me /cc @mgoelzer who was looking at this
There was a problem hiding this comment.
do we need the word 'default'? Some other address&port isn't going to be chosen, right?
There was a problem hiding this comment.
Yup, I noticed that as well, should just be Set address .. I think
Fixes moby#27843 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
7dc713c to
66c2549
Compare
|
@thaJeztah this has been updated |
This adds the cli docs for the metrics-addr flag and a small description on how it can be used.
We can add full api docs after this feature is removed from experimental as metrics and metric names can be modified or removed before then.
Fixes #27843
Signed-off-by: Michael Crosby crosbymichael@gmail.com