Update install.sh to set "experimental" to true if needed#27788
Update install.sh to set "experimental" to true if needed#27788mlaventure wants to merge 1 commit intomoby:masterfrom
Conversation
hack/install.sh
Outdated
There was a problem hiding this comment.
Isn't this one not supposed to be here ? 😝
There was a problem hiding this comment.
Nop, I was debugging 😅
|
/cc @tianon ptal 👼 |
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
fb8e17a to
2698479
Compare
|
Actually, this may need to be done in the |
|
@andrewhsu @tianon please take a look :) |
|
I'm personally -1 and would rather we document this well (and perhaps have the script link directly to the relevant section of the documentation for how to enable this). Is this one of the configuration items supported for live daemon configuration reload, or does this require a full daemon restart when changed? |
|
If I'm not mistaken, for now it requires a full daemon restart |
|
It requires a full restart indeed. We could just add a message at the end stating that the option needs to be On Mon, Nov 7, 2016 at 6:32 PM Victor Vieux notifications@github.com
|
|
@mlaventure yes, |
|
Alright, closing this then. |
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
This is a very conservative approach. We only update
/etc/docker/daemon.jsonif it doesn't exist yet.