Limit conccurent container creates in TestEventsLimit to 8#26968
Merged
crosbymichael merged 1 commit intomoby:masterfrom Sep 30, 2016
Merged
Limit conccurent container creates in TestEventsLimit to 8#26968crosbymichael merged 1 commit intomoby:masterfrom
crosbymichael merged 1 commit intomoby:masterfrom
Conversation
Member
|
I'm ok with this as an interim solution. Assuming it works 😄 Can you add a comment for why. Obviously we still need to track down the bug in Windows for servicing independently. IOW LGTM if CI passes a few runs. |
Signed-off-by: Darren Stahl <darst@microsoft.com>
f717729 to
728a265
Compare
Contributor
Author
|
This has passed CI without TestEventsLimit failures 5 times. Comment is updated, and ready for review 👍 |
Contributor
|
same as @jhowardmsft, "I'm ok with this as an interim solution" LGTM |
vieux
approved these changes
Sep 30, 2016
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22601
This limits the number of concurrent runs in TestEventsLimit in order to prevent hitting a platform timeout on Windows. I am unable to repro this failure locally, so this needs a few windowsRS1 CI runs to confirm the fix, but I strongly suspect this will fix the issue.
Assuming the platform timeout is the issue, the other option is to limit concurrency in the daemon, which might be the more correct solution here, since this solution (not changing anything) would require clients to limit their concurrent calls to creating containers on Windows until the platform timeout is changed. We could also temporarily disable the test until a platform fix is available, since I wouldn't really consider this a Docker bug, nor a test bug.
/cc @jhowardmsft @jstarks @jterry75 FYI