Removing old custom RootFS behavior on Windows.#25090
Removing old custom RootFS behavior on Windows.#25090LK4D4 merged 1 commit intomoby:masterfrom swernli:rootfs-cleanup
Conversation
|
Nice! LGTM once Janky passes. Has some import fixups required: |
|
LGTM |
|
LGTM, but ping @aaronlehmann @stevvooe for the change in image-specs |
daemon/oci_windows.go
Outdated
|
Seems fine to me. The base layer stuff was hack that we didn't want to support long-term. It's great that we're able to remove it. Normally there would be backward compatibility concerns, but I know the Windows daemon is not in wide use and there are not many images for it, so if you feel it's okay to get rid of this as a step change, that's fine with me. Needs a rebase though. |
image/spec/v1.1.md
Outdated
There was a problem hiding this comment.
We should probably leave this in or omit from OCI if we don't intend to support it going forward.
There was a problem hiding this comment.
Good point. I'll file an issue against @jstarks to get this removed from OCI.
There was a problem hiding this comment.
Actually, looks like you already opened that issue!
Windows base layers are no longer the special "layers+base" type, so we can remove all the special handling for that. Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
|
I think it has plenty of lgtms |
@jhowardmsft @jstarks
Windows base layers are no longer the special "layers+base" type, so we can remove all the special handling for that.
Signed-off-by: Stefan J. Wernli swernli@microsoft.com