Skip to content

Update engine-api#22422

Merged
cpuguy83 merged 1 commit into
moby:masterfrom
cpuguy83:vendor_engine-api
May 4, 2016
Merged

Update engine-api#22422
cpuguy83 merged 1 commit into
moby:masterfrom
cpuguy83:vendor_engine-api

Conversation

@cpuguy83

Copy link
Copy Markdown
Member

No description provided.

@cpuguy83

Copy link
Copy Markdown
Member Author

ping @vdemeester

19:44:23 FAIL: docker_cli_pull_test.go:201: DockerHubPullSuite.TestPullAllTagsFromCentralRegistry
19:44:23 
19:44:23 docker_cli_pull_test.go:211:
19:44:23     c.Assert(linesCount, checker.GreaterThan, 2, check.Commentf("pulling all tags should provide more than two images, got %s", outImageAllTagCmd))
19:44:23 ... obtained int = 2
19:44:23 ... expected int = 2
19:44:23 ... pulling all tags should provide more than two images, got REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
19:44:23 busybox             latest              47bcc53f74dc        6 weeks ago         1.113 MB
19:44:23 
19:44:23 
19:44:56 
19:44:56 ----------------------------------------------------------------------
19:44:56 PASS: docker_cli_pull_test.go:244: DockerHubPullSuite.TestPullClientDisconnect 3.214s
19:45:29 PASS: docker_cli_pull_test.go:17: DockerHubPullSuite.TestPullFromCentralRegistry   1.835s
19:46:08 PASS: docker_cli_pull_test.go:123: DockerHubPullSuite.TestPullFromCentralRegistryImplicitRefParts  8.759s
19:46:40 
19:46:40 ----------------------------------------------------------------------
19:46:40 FAIL: docker_cli_pull_test.go:41: DockerHubPullSuite.TestPullNonExistingImage
19:46:40 
19:46:40 docker_cli_pull_test.go:112:
19:46:40     c.Assert(record.out, checker.Contains, fmt.Sprintf("Error: image %s not found", record.e.repo), check.Commentf("expected image not found error messages"))
19:46:40 ... obtained string = "" +
19:46:40 ...     "Pulling repository docker.io/library/asdfasdf\n" +
19:46:40 ...     "Error: image library/asdfasdf:latest not found\n"
19:46:40 ... substring string = "Error: image library/asdfasdf not found"
19:46:40 ... expected image not found error messages
19:46:40 

@vdemeester

Copy link
Copy Markdown
Member

@cpuguy83 yes, #22247 is fixing it

@LK4D4

LK4D4 commented May 2, 2016

Copy link
Copy Markdown
Contributor

@cpuguy83 #22247 seems to be merged

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 force-pushed the vendor_engine-api branch from ced08e9 to 988f481 Compare May 2, 2016 18:17
@cpuguy83

cpuguy83 commented May 2, 2016

Copy link
Copy Markdown
Member Author

Updated

@vdemeester

Copy link
Copy Markdown
Member

LGTM 🐹

@runcom

runcom commented May 4, 2016

Copy link
Copy Markdown
Member

LGTM

@cpuguy83

cpuguy83 commented May 4, 2016

Copy link
Copy Markdown
Member Author

All 💚 merging.

@cpuguy83 cpuguy83 merged commit 973d6f0 into moby:master May 4, 2016
@cpuguy83 cpuguy83 deleted the vendor_engine-api branch May 4, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants