[WIP] Add forwarding local (client-side) sockets to container #19667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] -- DO NOT MERGE Adds an API endpoint for proxying socket conns from the client. This allows a client to forward a local socket (such as an SSH agent sock or an X11 socket) into a running container. This is currently just POC code, and it's not actually forwarding to the container, only to the host for simplicity while getting the connections actually working. Idea here is that any of the client commands that attach to the container in some way (exec, attach, run, build -- maybe) can take this new optional argument `--forward-socket <scheme>://<socket>` Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Member
Author
|
Also currently I am able to get a request to the forwarded socket, but not back from.... but lmk if this is desirable and I can continue working on it. Could at least solve the SSH secrets issue. |
Member
Author
|
Closing since this is just never going to work. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] -- DO NOT MERGE
Adds an API endpoint for proxying socket conns from the client.
This allows a client to forward a local socket (such as an SSH agent
sock or an X11 socket) into a running container.
This is currently just POC code, and it's not actually forwarding to the
container, only to the host for simplicity while getting the connections
actually working.
Idea here is that any of the client commands that attach to the
container in some way (exec, attach, run, build -- maybe) can take this
new optional argument
--forward-socket <scheme>://<socket>Signed-off-by: Brian Goff cpuguy83@gmail.com