Enable golint in pkg/jsonlog and pkg/jsonmessage part of #14756#15074
Enable golint in pkg/jsonlog and pkg/jsonmessage part of #14756#15074cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
e760b59 to
19441a6
Compare
pkg/jsonlog/jsonlog.go
Outdated
There was a problem hiding this comment.
Perhaps document how the format string is interpreted.
|
Ping @coolljt0725 |
|
@tiborvass sorry ,a bit busy these days, I'll update this tomorrow |
|
@coolljt0725 no worries! Thanks for the heads-up! |
8cb3c0c to
6001dd6
Compare
|
@tiborvass @aaronlehmann updated. For the name of |
pkg/jsonmessage/jsonmessage.go
Outdated
There was a problem hiding this comment.
please be a bit more specific with what it does with in and out and isTerminal
6001dd6 to
cba7a12
Compare
|
@tiborvass updated |
|
Just added a couple of suggestions on the comments to add more informations and to correct some mistakes 😃, other than that LGTM |
cba7a12 to
257f69f
Compare
|
@abronan Thanks, updated |
pkg/jsonlog/jsonlog.go
Outdated
There was a problem hiding this comment.
It would be helpful to put what a JSONLog is, what it is used for.
Think about a newcomer reading and trying to figure it out.
There was a problem hiding this comment.
JSONLog represents a log message, typically a single entry from a given log stream.
JSONLogs can be easily serialized to and from JSON and support custom formatting.
257f69f to
5220f3b
Compare
Signed-off-by: Lei Jitang <leijitang@huawei.com>
pkg/jsonlog
pkg/jsonmessage
Signed-off-by: Lei Jitang leijitang@huawei.com