daemon/graphdriver/overlay/ fix lint errors/warnings#15014
daemon/graphdriver/overlay/ fix lint errors/warnings#15014calavera merged 1 commit intomoby:masterfrom
Conversation
c05616e to
47d89da
Compare
There was a problem hiding this comment.
Makes sense to add info about an error if overlay fs isn't supported.
e81922b to
14fa3ac
Compare
|
Seems good once CI passes. No lint errors Maybe verify if |
22b1836 to
ca2271b
Compare
|
Needs rebase. |
ca2271b to
cb71295
Compare
|
@icecrime rebased. |
|
@brahmaroutu needs another rebase :( |
cb71295 to
a94dc01
Compare
|
Done @tiborvass |
There was a problem hiding this comment.
applyDiffProtoDriver needs to be exported, interfaces are sometimes the exception to the rule: they are useful to be visible outside the package, so that clients that want to implement it know what methods to implement. Otherwise, how do you know what to pass to NaiveDiffDriverWithApply if you don't know that it's just a ProtoDriver with ApplyDiff?
There was a problem hiding this comment.
I agree, good to spec out the interface implementation. Please review the comments. @tiborvass
a94dc01 to
242c61f
Compare
There was a problem hiding this comment.
Should add This is required to satisfy the graphdriver.Driver interface (or is it ProtoDriver?)
|
Couple of comments. Also needs a rebase. |
Addresses moby#14756 Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
242c61f to
de39442
Compare
Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com