daemon/graphdriver/devmapper/ fix lint errors/warnings#14930
Merged
tiborvass merged 1 commit intomoby:masterfrom Jul 29, 2015
Merged
daemon/graphdriver/devmapper/ fix lint errors/warnings#14930tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
Member
There was a problem hiding this comment.
s/usagei/usage/
s/used/and is used/
4499543 to
e949bba
Compare
e949bba to
bf9dece
Compare
Contributor
There was a problem hiding this comment.
this description seems unfinished.
bf9dece to
3787f5a
Compare
Contributor
There was a problem hiding this comment.
Why is this capitalized?
Contributor
|
@brahmaroutu Also need rebase :/ |
3787f5a to
1fb052f
Compare
Contributor
|
LGTM. Thanks @brahmaroutu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
Apart from making golint run, I have changed many variables and methods to local. Hope this devmapper pakage(not under pkg) is not used outside of docker code base. Please review.