Merged
Conversation
api/server/server.go
Outdated
Member
There was a problem hiding this comment.
@brahmaroutu you don't need to add the -. I think the "look" of godoc will be a little weird.
df1ab18 to
9230553
Compare
8027ecc to
9858eb8
Compare
api/server/server.go
Outdated
Member
There was a problem hiding this comment.
I'm not sure about this change, as APIServerConfig repeat the api/server part. Config would be simpler 😊. Below you end up with apiserver.APIServerConfig in daemon.go which would look way cleaner like apiserver.Config.
Member
|
Few comments. See also #14751 (comment), you need a period at the end of the sentences for the func comments. 😉 |
9858eb8 to
06a1eed
Compare
Contributor
Author
|
@vdemeester Please review. |
api/server/server_linux.go
Outdated
Member
|
@brahmaroutu Could you add the package |
9b1efc9 to
056ef00
Compare
Contributor
There was a problem hiding this comment.
let's write http.Server and net.Listener to have reference to real types in godoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com