Skip to content

docker cp++#14058

Closed
jlhawn wants to merge 1 commit intomoby:masterfrom
jlhawn:docker_cp_plus_plus
Closed

docker cp++#14058
jlhawn wants to merge 1 commit intomoby:masterfrom
jlhawn:docker_cp_plus_plus

Conversation

@jlhawn
Copy link
Contributor

@jlhawn jlhawn commented Jun 20, 2015

This pull request builds on top of #13171 by adding support for container paths which contain shell globs, and general support for multiple source arguments when copying.

@jlhawn jlhawn mentioned this pull request Jun 20, 2015
Merged
@icecrime icecrime mentioned this pull request Jun 30, 2015
Closed
2 tasks
@jlhawn jlhawn force-pushed the docker_cp_plus_plus branch 5 times, most recently from d7536dc to 476d011 Compare July 8, 2015 21:15
@thaJeztah thaJeztah added this to the 1.8.0 milestone Jul 10, 2015
@thaJeztah
Copy link
Member

thaJeztah commented Jul 10, 2015

Added this to the 1.8 milestone (see the roadmap wiki)

@thaJeztah thaJeztah mentioned this pull request Jul 10, 2015
Closed
@jlhawn jlhawn force-pushed the docker_cp_plus_plus branch from 476d011 to 31b0421 Compare July 14, 2015 17:43
@icecrime
Copy link
Contributor

icecrime commented Jul 20, 2015

Removing from 1.8 milestone: let's focus on #13171.

@icecrime icecrime removed this from the 1.8.0 milestone Jul 20, 2015
@jlhawn
Copy link
Contributor Author

jlhawn commented Jul 20, 2015

👍

@jlhawn jlhawn force-pushed the docker_cp_plus_plus branch 2 times, most recently from da95372 to c79cc43 Compare July 21, 2015 23:45
FIXUP: docker cp with multiple sources and globs
e34d0c3 
Adds an API endpoint for expanding glob patterns to match paths in a container.
Adds support for multiple sources in `docker cp`.
Expands container source paths as globs before copying.

Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
@jlhawn jlhawn force-pushed the docker_cp_plus_plus branch from c79cc43 to e34d0c3 Compare July 22, 2015 00:08
@jlhawn
Copy link
Contributor Author

jlhawn commented Jul 25, 2015

Since filepath.Glob will follow symlinks, the best way to do this will probably be to do a re-exec with a chroot, resolve the patters from there, then return those.

@icecrime
Copy link
Contributor

icecrime commented Aug 7, 2015

I'm happy with the new cp: do we really need this?

@cpuguy83
Copy link
Member

cpuguy83 commented Aug 24, 2015

As much as docker cp can behave like cp/scp it would be great.

@rgarbin
Copy link

rgarbin commented Sep 1, 2015

The new docker cp has documentation?
https://docs.docker.com/reference/api/docker_remote_api_v1.18/

@thaJeztah
Copy link
Member

thaJeztah commented Sep 1, 2015

@rgarbin you probably have to look in API v1.20 for the new cp functionality

@calavera
Copy link
Contributor

calavera commented Sep 9, 2015

@jlhawn I think this needs additional tests for the functionality that's adding and documentation. I just moved it to code-review.

@jlhawn
Copy link
Contributor Author

jlhawn commented Sep 9, 2015

I'm closing for now as I haven't maintained this feature in a while and there's also a potential security issue with the glob matching (might be best to do it in a chroot).

@jlhawn jlhawn closed this Sep 9, 2015
@jlhawn
Copy link
Contributor Author

jlhawn commented Sep 9, 2015

I'll reopen again soon when I have a chance to update it.

@jlhawn jlhawn deleted the docker_cp_plus_plus branch November 22, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jlhawn @thaJeztah @icecrime @cpuguy83 @rgarbin @calavera @LK4D4 @GordonTheTurtle