[WIP] Add docker daemon to bash completion#13934
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
|
you're awesome, @albers! I'm not very well at these scripts to review, just ❤️ |
|
Thanks @albers would you mind closing this PR until the other one is merged? You can then reopen it before pushing to the branch. We don't like to have dependencies among PRs :) Thanks for your work though, really appreciated. |
|
Temporarily closed as requested by @tiborvass. |
|
Reopening as #13771 is merged. |
|
Will take care of the conflicts in about a week. |
|
I added this to the 1.8 milestone, because it's part of #13771 ping @calavera for #13934 (comment), because I don't know when code-freeze is for 1.8 (but I assume we can get this in during the release-candidates as well) |
|
There was a discussion recently that the completions are sort of tooling and therefore should not be strictly impacted by code freeze, see here. |
|
@albers Needs rebase, sorry! |
|
No problem, rebase is mostly due to changes of my own. |
docker daemon to bash completiondocker daemon to bash completion
|
@albers sorry need a rebase :) Also, the "global flags" (-D, --tls, ...) are now valid after the |
|
@albers did you have time to look into this? I'd ❤️ to have it ready for the RC2. |
|
@calavera I will do it on friday. Sorry, can't get to it earlier. |
|
@albers no problem I'll carry it. Thanks for your help so far! |
|
Carried in #15166 |
This amends #13771. It assumes that the changes to bash completion in that PR are removed.
ping @tianon @jfrazelle for review
ping @tiborvass @thaJeztah
Also renamed
$main_options_with_argsto$global_options_with_argsto make its intent clearer.Got rid of
$global_options_with_args_globby inlining.Will add the zfs storage driver in another PR.